Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run local tests in TravisCI #74

Merged
merged 2 commits into from Feb 16, 2019
Merged

Run local tests in TravisCI #74

merged 2 commits into from Feb 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2019

Fixes #72

Changing the /usr/local/ folder permissions before the install solved the issue with the tests in Travis. This will run the tests fine but I think that on the long run it will be better to change the folder where squash stores the sh files to somewhere we don't have to change permissions.

Check everything which applies

  • I have added the issue number for which this pull request is created.

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks.

@arshadkazmi42
Copy link
Owner

but I think that on the long run it will be better to change the folder where squash stores the sh files to somewhere we don't have to change permissions.

Do you have any suggestions for location? where we can store sh files without permission changes

@arshadkazmi42 arshadkazmi42 merged commit 0a45676 into arshadkazmi42:master Feb 16, 2019
@ghost ghost deleted the travis-ci-local-tests branch February 16, 2019 10:25
@ghost ghost mentioned this pull request Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant