Slow controls unit transformations #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 28, 2024 20:51
…ormula in otsdaq/FECore/FEVInterface.cc.
…olsChannel.cc and otsdaq/FECore/FESlowControlsChannel.hh.
…q/FECore/FEVInterface.cc.
rrivera747
reviewed
Mar 29, 2024
otsdaq/FECore/FEVInterface.cc
Outdated
| try { | ||
| transformation = groupLinkChild.second.getNode("Transformation").getValue<std::string>(); | ||
| } catch (...) { | ||
| __FE_COUT__ << "Slow controls 'Transformation' setting found." << __E__; |
There was a problem hiding this comment.
Should this be "setting not found" instead of "setting found"?
There was a problem hiding this comment.
Thanks for spotting that, it's fixed now.
…nger than a bare 'x'.
eflumerf
reviewed
Apr 5, 2024
| __FE_COUT__ << "Transformation formula = " <<channel->transformation_ << __E__; | ||
|
|
||
| TFormula transformationFormula("transformationFormula", (channel->transformation_).c_str()); | ||
| double transformedVal = transformationFormula.Eval(val); |
There was a problem hiding this comment.
Probably a good idea to check for NaN here, instead of just reporting the value
There was a problem hiding this comment.
I added an isnan check for transformedVal, which throws a COUT_ERR if it fails.
added 2 commits
April 10, 2024 14:25
…nt/slowControlsUnitTransforms
rrivera747
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented unit conversions for slow controls parameters using
ROOT(TFormula). The transformation formula is defined inFESlowControlsTable, and the transformation is applied inFEVInterface.cc-- just before the value is sent to the metrics manager.I have used this to read transformed values back through both
Graphite/GrafanaandEPICS.Note: due to the way that ROOT interprets formulas as strings, the variable in the transformation formula must be an
"x", e.g."2*x+1". I have set"x"to be the default formula in the table.