Improved handling of numbers in tables; issues were seen comparing nu… #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mber values to min and max values, which required the use of type double - issue resolved and handling simplified.
eflumerf
reviewed
Apr 8, 2024
| @@ -2888,7 +2892,7 @@ int TableView::fillFromCSV(const std::string& data, const int& dataOffset, const | |||
| // if row was modified, assign author and timestamp | |||
| if(author != "" && rowWasModified) | |||
| { | |||
| __COUT__ << "Row=" << (int)r << " was modified!" << __E__; | |||
| __COUT_TYPE__(TLVL_DEBUG+20) << "Row=" << (int)r << " was modified!" << __E__; | |||
There was a problem hiding this comment.
I'm increasingly of the opinion that these macros do not help, and make things harder to understand. Is there any reason to not change to TLOG() throughout?
eflumerf
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mber values to min and max values, which required the use of type double - issue resolved and handling simplified.