Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint after updates from Calorimeter Pisa VST commissioning #157

Merged
merged 7 commits into from Apr 17, 2024
Merged

Checkpoint after updates from Calorimeter Pisa VST commissioning #157

merged 7 commits into from Apr 17, 2024

Conversation

rrivera747
Copy link
Contributor

No description provided.

@eflumerf
Copy link
Contributor

There appear to be a few member variables of member pointers accessed in here...things like channel->fullChannelName_ seem to be a code smell (if struct, then get rid of the trailing underscore, if class, add an accessor method).

eflumerf
eflumerf previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, because naming conventions are not something we really need to get into right now

@rrivera747 rrivera747 merged commit ed05370 into develop Apr 17, 2024
4 checks passed
@rrivera747 rrivera747 deleted the rrivera/pisaSlowControlsUpdates branch April 17, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eflumerf eflumerf eflumerf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
art-daq Work Tracker
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rrivera747 @eflumerf