Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transition Configured -> Halted in the ots State Machine #69

Merged
merged 1 commit into from Dec 21, 2022

Conversation

mrigatti
Copy link
Contributor

@mrigatti mrigatti commented Dec 8, 2022

No description provided.

@@ -107,6 +107,17 @@ CorePropertySupervisorBase::CorePropertySupervisorBase(xdaq::Application* applic
__SUP_COUTV__(CorePropertySupervisorBase::supervisorApplicationUID_);
__SUP_COUTV__(CorePropertySupervisorBase::supervisorConfigurationPath_);

//try to verify binding port for context was established
//All this code failed to do the trick
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be removed, then?

Copy link
Contributor

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for potentially adding more commented code to the repo, this all looks fine.

@eflumerf eflumerf merged commit dd40548 into develop Dec 21, 2022
@eflumerf eflumerf deleted the mrigatti/hwdev branch December 21, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants