-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update msg for support in ROS Iron #2
base: master
Are you sure you want to change the base?
Conversation
@fabid I have confirmed that we don't need to add any if condition here. |
actually I think I made a mistake yesterday to talk about a condition based on ros version, but there might be a need to make a change base on MoveIt version, right? |
Except humble this change works with every ros version. |
Do you mean every ROS version newer than Humble? (I suspect it won't work with Foxy if it doesn't with Humble). And so can we modify the PR to make it work including on Humble, with some conditional, so that it can be merged in main? I also realized that on top of providing latest |
I will track it down |
Option1: find a way to find moveit2 version and add a conditional: |
@Apurv354 any update on this one? |
@fabid I went through the git history of moveit_ros_msgs. It is a bit complicated but I saw they have a master branch which has the most up-to-date code and there are several ros branches. They merged this master to Iron 7 months ago which brought the change - moveit/moveit_msgs@1fe0082 There is no update to the humble branch that's why the code fails in ros_moveit_msgs - humble. |
thank you @Apurv354 for digging. Could you double check your link? it is directing me to a CI workflow change |
this PR? moveit/moveit_msgs#130 |
Changelog of moveit_msgs: https://github.com/ros-planning/moveit_msgs/blob/9756797dcbc293c7cae66541a7bc0c7acec85892/CHANGELOG.rst#L12 I cannot find a clear reference of the matching moveit2 version, even the ubuntu package directory does not display matching versions https://index.ros.org/p/moveit_msgs/#rolling So I would say that based on our tests, the change in this PR should target iron and rolling |
No description provided.