Fix find_character_info #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the hex conversion of character_id to trim the first two characters instead of replacing X with '' Modified the find_character_info to make it so partial matches are checked for 5, 4 and 3 characters sequentially and leading zeroes are ignored in both the converted hex value from the game and the hex value in the baseID in the character.csv. There's also a few check in there to account for float & NaN values
art-from-the-machine
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I've been tinkering to solve this issue that some users are having where the getdisplayname() function fails to run in Fallout 4 leading to the game not loading NPC profiles correctly. That prompted me to look into why the ID search in the Mantella Software lookup functions weren't picking up the slack when the name is missing.
Changes:
Modified the hex conversion of character_id to trim the first two characters instead of replacing X with '' Modified the find_character_info to make it so partial matches are checked for 5, 4 and 3 characters sequentially and leading zeroes are ignored in both the converted hex value from the game and the hex value in the baseID in the character.csv. There's also a few check in there to account for float & NaN values