Jsoo sherlodoc #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9159abc.
* make test on base faster by making the slowest part cachable by dune * do not call odig inside cram tests : this is important because odig can have issues --------- Co-authored-by: Emile Trotignon <emile@tarides.com>
|
Thanks again for all the work! ❤️ It's been deployed to doc.sherlocode.com a few days ago and seems to work well enough... so let's merge! Any remaining issues can be addressed in follow-up PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a lot of changes. I will try to broadly describe them.
odococaml/odoc#972I have probably forgotten some things, I will come back and add details later.