Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the engine.remove method to allow instance deletion from a query #237

Merged
merged 8 commits into from Aug 24, 2022

Conversation

art049
Copy link
Owner

@art049 art049 commented Aug 19, 2022

Continuing the initial work from @joeriddles in #147

@art049 art049 force-pushed the feature/delete_many branch 2 times, most recently from 6cdd0ca to 3a82be1 Compare August 19, 2022 12:59
@github-actions
Copy link

github-actions bot commented Aug 19, 2022

🚀 Deployed on https://docs-preview-237--odmantic.netlify.app

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #237 (a52d9c9) into master (27ff069) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #237   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         3480      3560   +80     
  Branches       590       596    +6     
=========================================
+ Hits          3480      3560   +80     
Flag Coverage Δ
tests-3.10-4-standalone 97.92% <74.71%> (-0.59%) ⬇️
tests-3.10-4.2-standalone 97.92% <74.71%> (-0.59%) ⬇️
tests-3.10-4.4-standalone 97.92% <74.71%> (-0.59%) ⬇️
tests-3.7-4-standalone 97.95% <74.71%> (-0.60%) ⬇️
tests-3.7-4.2-standalone 97.95% <74.71%> (-0.60%) ⬇️
tests-3.7-4.4-standalone 97.95% <74.71%> (-0.60%) ⬇️
tests-3.8-4-replicaSet 98.73% <100.00%> (+0.02%) ⬆️
tests-3.8-4-standalone 97.92% <74.71%> (-0.59%) ⬇️
tests-3.8-4.2-sharded 96.76% <74.71%> (-0.56%) ⬇️
tests-3.8-4.2-standalone 97.92% <74.71%> (-0.59%) ⬇️
tests-3.8-4.4-standalone 97.92% <74.71%> (-0.59%) ⬇️
tests-3.9-4-standalone 97.80% <74.71%> (-0.59%) ⬇️
tests-3.9-4.2-standalone 97.80% <74.71%> (-0.59%) ⬇️
tests-3.9-4.4-standalone 97.80% <74.71%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/engine.py 100.00% <100.00%> (ø)
tests/integration/test_engine.py 100.00% <100.00%> (ø)
tests/integration/test_engine_reference.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@art049
Copy link
Owner Author

art049 commented Aug 23, 2022

Will be merged after #231

@art049 art049 changed the title Add engine.remove method Implement the engine.remove method to allow instance deletion from a query Aug 24, 2022
@art049 art049 merged commit 6f64015 into master Aug 24, 2022
@art049 art049 deleted the feature/delete_many branch August 24, 2022 23:35
@art049 art049 mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants