Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new types instead of changing type args for structural types #240

Merged
merged 4 commits into from
Sep 25, 2022

Conversation

art049
Copy link
Owner

@art049 art049 commented Aug 23, 2022

Continues #220 created by @erny
Closes #200 and will fix #66

Type equality tests are failing because of python/cpython#97543

@art049 art049 changed the title Creat new types instead of changing Create new types instead of changing type args for structural types #2 Aug 23, 2022
@github-actions
Copy link

github-actions bot commented Aug 23, 2022

🚀 Deployed on https://docs-preview-240--odmantic.netlify.app

@art049 art049 force-pushed the creat-new-types-instead-of-changing branch from 6ac7589 to afc02ac Compare August 23, 2022 15:43
@art049 art049 force-pushed the creat-new-types-instead-of-changing branch from 7344f33 to 49376a8 Compare September 25, 2022 12:50
@art049 art049 changed the title Create new types instead of changing type args for structural types #2 Create new types instead of changing type args for structural types Sep 25, 2022
@art049 art049 force-pushed the creat-new-types-instead-of-changing branch 2 times, most recently from 0816f42 to 933218d Compare September 25, 2022 14:58
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #240 (760bea2) into master (62fe42c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        47    +2     
  Lines         4908      4944   +36     
  Branches       874       879    +5     
=========================================
+ Hits          4908      4944   +36     
Flag Coverage Δ
tests-3.10-4.4-standalone 94.35% <95.74%> (+<0.01%) ⬆️
tests-3.10-5-standalone 94.35% <95.74%> (+<0.01%) ⬆️
tests-3.10-6-standalone 94.35% <95.74%> (+<0.01%) ⬆️
tests-3.7-4.4-standalone 92.62% <87.23%> (-0.07%) ⬇️
tests-3.7-5-standalone 92.62% <87.23%> (-0.07%) ⬇️
tests-3.7-6-standalone 92.62% <87.23%> (-0.07%) ⬇️
tests-3.8-4-replicaSet 98.94% <87.23%> (-0.12%) ⬇️
tests-3.8-4.2-sharded 93.44% <87.23%> (-0.08%) ⬇️
tests-3.8-4.4-standalone 94.27% <87.23%> (-0.09%) ⬇️
tests-3.8-5-standalone 94.27% <87.23%> (-0.09%) ⬇️
tests-3.8-6-standalone 94.27% <87.23%> (-0.09%) ⬇️
tests-3.9-4.4-standalone 94.27% <95.74%> (+<0.01%) ⬆️
tests-3.9-5-standalone 94.27% <95.74%> (+<0.01%) ⬆️
tests-3.9-6-standalone 94.27% <95.74%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/engine.py 100.00% <100.00%> (ø)
odmantic/model.py 100.00% <100.00%> (ø)
odmantic/query.py 100.00% <100.00%> (ø)
odmantic/typing.py 100.00% <100.00%> (ø)
tests/integration/test_types.py 100.00% <100.00%> (ø)
tests/test_typing_utils.py 100.00% <100.00%> (ø)
tests/typing_utils.py 100.00% <100.00%> (ø)
tests/unit/test_model_definition.py 100.00% <100.00%> (ø)
tests/unit/test_model_type_validation.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@art049 art049 force-pushed the creat-new-types-instead-of-changing branch from 0df4d12 to 760bea2 Compare September 25, 2022 15:59
@art049 art049 merged commit e74638f into master Sep 25, 2022
@art049 art049 deleted the creat-new-types-instead-of-changing branch September 25, 2022 16:10
@art049 art049 mentioned this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants