Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save using an embedded model as a primary key #258

Merged
merged 1 commit into from Sep 6, 2022

Conversation

art049
Copy link
Owner

@art049 art049 commented Sep 6, 2022

Fixes #94

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

🚀 Deployed on https://docs-preview-258--odmantic.netlify.app

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #258 (49ee94c) into master (c0b46e7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         4130      4149   +19     
  Branches       678       682    +4     
=========================================
+ Hits          4130      4149   +19     
Flag Coverage Δ
tests-3.10-4.4-standalone 93.32% <100.00%> (+0.03%) ⬆️
tests-3.10-5-standalone 93.32% <100.00%> (+0.03%) ⬆️
tests-3.10-6-standalone 93.32% <100.00%> (+0.03%) ⬆️
tests-3.7-4.4-standalone 91.36% <100.00%> (+0.04%) ⬆️
tests-3.7-5-standalone 91.36% <100.00%> (+0.04%) ⬆️
tests-3.7-6-standalone 91.36% <100.00%> (+0.04%) ⬆️
tests-3.8-4-replicaSet 98.89% <100.00%> (+<0.01%) ⬆️
tests-3.8-4.2-sharded 92.33% <100.00%> (+0.03%) ⬆️
tests-3.8-4.4-standalone 93.32% <100.00%> (+0.03%) ⬆️
tests-3.8-5-standalone 93.32% <100.00%> (+0.03%) ⬆️
tests-3.8-6-standalone 93.32% <100.00%> (+0.03%) ⬆️
tests-3.9-4.4-standalone 93.22% <100.00%> (+0.03%) ⬆️
tests-3.9-5-standalone 93.22% <100.00%> (+0.03%) ⬆️
tests-3.9-6-standalone 93.22% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/engine.py 100.00% <100.00%> (ø)
tests/integration/test_embedded_model.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@art049 art049 merged commit 024937b into master Sep 6, 2022
@art049 art049 deleted the fix-embedded-model-as-primary-key branch September 6, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use an EmbeddedModel as a primary field
1 participant