Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmbeddedModel generics definition with a custom key_name #269

Merged
merged 7 commits into from
Sep 25, 2022

Conversation

art049
Copy link
Owner

@art049 art049 commented Sep 24, 2022

Fixes #263

TODO:

  • Fix coverage
  • Change spurious realworld-test implementation

@art049 art049 force-pushed the fix-embedded-model-list-with-key-name branch from 9fe5af9 to f3e87e0 Compare September 24, 2022 13:56
@github-actions
Copy link

github-actions bot commented Sep 24, 2022

🚀 Deployed on https://docs-preview-269--odmantic.netlify.app

@art049 art049 force-pushed the fix-embedded-model-list-with-key-name branch from f3e87e0 to 496d6a0 Compare September 24, 2022 14:03
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #269 (0fac238) into master (775966b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #269    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           44        45     +1     
  Lines         4679      4884   +205     
  Branches       808       870    +62     
==========================================
+ Hits          4679      4884   +205     
Flag Coverage Δ
tests-3.10-4.4-standalone 94.32% <99.58%> (+0.24%) ⬆️
tests-3.10-5-standalone 94.32% <99.58%> (+0.24%) ⬆️
tests-3.10-6-standalone 94.32% <99.58%> (+0.24%) ⬆️
tests-3.7-4.4-standalone 92.65% <99.58%> (+0.32%) ⬆️
tests-3.7-5-standalone 92.65% <99.58%> (+0.32%) ⬆️
tests-3.7-6-standalone 92.65% <99.58%> (+0.32%) ⬆️
tests-3.8-4-replicaSet 99.05% <99.58%> (+0.04%) ⬆️
tests-3.8-4.2-sharded 93.48% <99.58%> (+0.28%) ⬆️
tests-3.8-4.4-standalone 94.32% <99.58%> (+0.24%) ⬆️
tests-3.8-5-standalone 94.32% <99.58%> (+0.24%) ⬆️
tests-3.8-6-standalone 94.32% <99.58%> (+0.24%) ⬆️
tests-3.9-4.4-standalone 94.24% <99.58%> (+0.25%) ⬆️
tests-3.9-5-standalone 94.24% <99.58%> (+0.25%) ⬆️
tests-3.9-6-standalone 94.24% <99.58%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/exceptions.py 100.00% <100.00%> (ø)
odmantic/field.py 100.00% <100.00%> (ø)
odmantic/model.py 100.00% <100.00%> (ø)
odmantic/typing.py 100.00% <100.00%> (ø)
tests/integration/test_embedded_model.py 100.00% <100.00%> (ø)
tests/integration/test_engine.py 100.00% <100.00%> (ø)
tests/unit/test_model_definition.py 100.00% <100.00%> (ø)
tests/unit/test_model_logic.py 100.00% <100.00%> (ø)
tests/unit/test_typing.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@art049 art049 changed the title Fix EmbeddedModel list definition with a custom key_name Fix EmbeddedModel generics definition with a custom key_name Sep 24, 2022
@art049 art049 force-pushed the fix-embedded-model-list-with-key-name branch 3 times, most recently from ec470d8 to 299231a Compare September 24, 2022 15:05
@art049 art049 force-pushed the fix-embedded-model-list-with-key-name branch 3 times, most recently from aafb026 to 97278d4 Compare September 24, 2022 15:28
@art049 art049 force-pushed the fix-embedded-model-list-with-key-name branch from 97278d4 to 29f79e8 Compare September 24, 2022 15:37
@art049 art049 force-pushed the fix-embedded-model-list-with-key-name branch from edf8d37 to 0fac238 Compare September 25, 2022 12:21
@art049 art049 merged commit 4d7236d into master Sep 25, 2022
@art049 art049 deleted the fix-embedded-model-list-with-key-name branch September 25, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with list of EmbeddedModel whose fields use key_name
1 participant