-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options and SIGINT handling #1
Conversation
… and add --region, --started-by and --env
index.js
Outdated
let params = { | ||
clusterArn: options.clusterArn, | ||
taskId: taskId, | ||
reason: 'User cancelled tasked' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be User requested interrupt
lib/taskrunner.js
Outdated
}, | ||
|
||
stop: function(options, cb) { | ||
let ecs = new AWS.ECS(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a const
lib/taskrunner.js
Outdated
|
||
stop: function(options, cb) { | ||
let ecs = new AWS.ECS(); | ||
let params = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a const
index.js
Outdated
process.on('SIGINT', () => { | ||
console.log(`Received SIGINT. Asking ECS to stop task: ${taskId}`); | ||
|
||
let params = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a const
index.js
Outdated
@@ -27,7 +27,7 @@ module.exports = function(options, cb) { | |||
|
|||
async.waterfall([ | |||
function(next) { | |||
var ecs = new AWS.ECS(); | |||
let ecs = new AWS.ECS(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a const.
No description provided.