ESM module export (#821)

* test: add reproduction repo for module export Repo is copied from #816 inside to test in future * fix(all-settled): bundler esm import fix(async): bundler esm import fix(core-v1): bundler esm import fix(core): bundler esm import fix(effects): bundler esm import fix(eslint-plugin): bundler esm import fix(form-web): bundler esm import fix(form): bundler esm import fix(framework): bundler esm import fix(hooks): bundler esm import fix(jsx): bundler esm import fix(lens): bundler esm import fix(logger): bundler esm import fix(npm-cookie-baker): bundler esm import fix(npm-history): bundler esm import fix(npm-lit): bundler esm import fix(npm-react): bundler esm import fix(npm-solid-js): bundler esm import fix(npm-svelte): bundler esm import fix(npm-vue): bundler esm import fix(persist-web-storage): bundler esm import fix(persist): bundler esm import fix(primitives): bundler esm import fix(react-v1): bundler esm import fix(testing): bundler esm import fix(timer): bundler esm import fix(undo): bundler esm import fix(url): bundler esm import fix(utils): bundler esm import fix(web-fetch): bundler esm import fix(web): bundler esm import Reatom used to use package.json#module field to declare esm modules. Turns out it was only in draft spec and never was standardized. So instead of relying on non-standard behaviour we use .mjs which is standard nodejs mechanizm. Should fix #816 #806 #573 * fix(new-package-template): use mjs in module export * test: implement cjs and esm check test * chore: install test files
artalar · Jun 14, 2024 · b8bb007 · b8bb007
1 parent 31c7ad2
commit b8bb007
Show file tree

Hide file tree

Showing 41 changed files with 205 additions and 69 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/all-settled/package.json b/packages/all-settled/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/async/package.json b/packages/async/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/cjs-import-check/README.md b/packages/cjs-import-check/README.md
@@ -0,0 +1,10 @@
+#reatom CJS issue
+Reproduce for CJS-related reatom issue
+
+This repo is used to reproduce problems with import of "module" exported files.
+
+```
+yarn
+yarn build
+yarn start
+```
diff --git a/packages/cjs-import-check/package.json b/packages/cjs-import-check/package.json
@@ -0,0 +1,20 @@
+{
+  "name": "@reatom-private/cjs-import-check",
+  "version": "1.0.0",
+  "main": "index.js",
+  "type": "commonjs",
+  "private": true,
+  "license": "MIT",
+  "dependencies": {
+    "@reatom/framework": "^3.4.37"
+  },
+  "scripts": {
+    "build": "tsc -p tsconfig.json",
+    "start": "node ./dist/hello.js",
+    "pretest": "npm run build",
+    "test": "node ./dist/hello.js"
+  },
+  "devDependencies": {
+    "typescript": "5.4.5"
+  }
+}
diff --git a/packages/cjs-import-check/src/hello.ts b/packages/cjs-import-check/src/hello.ts
@@ -0,0 +1,4 @@
+const {atom, createCtx} = require('@reatom/framework')
+const me = atom('check ✅', 'me')
+const ctx = createCtx()
+console.log('CommonJS import:', ctx.get(me))
diff --git a/packages/cjs-import-check/tsconfig.json b/packages/cjs-import-check/tsconfig.json
@@ -0,0 +1,14 @@
+{
+    "compilerOptions": {
+      "rootDir": "src",
+      "target": "ES2022",
+      "module": "ES2022",
+      "moduleResolution": "Node10",
+      "esModuleInterop": true,
+      "forceConsistentCasingInFileNames": true,
+      "strict": true,
+      "skipLibCheck": true,
+      "outDir": "./dist",
+    },
+  }
+
diff --git a/packages/core-v1/package.json b/packages/core-v1/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -7,10 +7,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "sideEffects": false,
   "browserslist": [

diff --git a/packages/effects/package.json b/packages/effects/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -11,10 +11,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "node 16"

diff --git a/packages/esm-import-check/README.md b/packages/esm-import-check/README.md
@@ -0,0 +1,10 @@
+#reatom esm issue
+Reproduce for ESM-related reatom issue
+
+This repo is used to reproduce problems with import of "module" exported files.
+
+```
+yarn
+yarn build
+yarn start
+```
diff --git a/packages/esm-import-check/package.json b/packages/esm-import-check/package.json
@@ -0,0 +1,20 @@
+{
+  "name": "@reatom-private/esm-import-check",
+  "version": "1.0.0",
+  "main": "index.js",
+  "type": "module",
+  "license": "MIT",
+  "private": true,
+  "dependencies": {
+    "@reatom/framework": "^3.4.37"
+  },
+  "scripts": {
+    "build": "tsc -p tsconfig.json",
+    "start": "node ./dist/hello.js",
+    "pretest": "npm run build",
+    "test": "node ./dist/hello.js"
+  },
+  "devDependencies": {
+    "typescript": "5.4.5"
+  }
+}
diff --git a/packages/esm-import-check/src/hello.ts b/packages/esm-import-check/src/hello.ts
@@ -0,0 +1,4 @@
+import {atom, createCtx} from '@reatom/framework'
+const me = atom('check ✅', 'me')
+const ctx = createCtx()
+console.log('ESM import:', ctx.get(me))
diff --git a/packages/esm-import-check/tsconfig.json b/packages/esm-import-check/tsconfig.json
@@ -0,0 +1,14 @@
+{
+    "compilerOptions": {
+      "rootDir": "src",
+      "target": "ES2022",
+      "module": "ES2022",
+      "moduleResolution": "Bundler",
+      "esModuleInterop": true,
+      "forceConsistentCasingInFileNames": true,
+      "strict": true,
+      "skipLibCheck": true,
+      "outDir": "./dist",
+    },
+  }
+
diff --git a/packages/form-web/package.json b/packages/form-web/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/form/package.json b/packages/form/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/framework/package.json b/packages/framework/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": ["last 1 year"],
   "minify": { "mangle": false },

diff --git a/packages/hooks/package.json b/packages/hooks/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/jsx/package.json b/packages/jsx/package.json
@@ -8,19 +8,19 @@
   "exports": {
     ".": {
       "types": "./build/index.d.ts",
-      "default": "./build/index.module.js"
+      "default": "./build/index.mjs"
     },
     "./jsx-runtime": {
       "types": "./build/index.d.ts",
-      "default": "./build/index.module.js"
+      "default": "./build/index.mjs"
     },
     "./jsx-dev-runtime": {
       "types": "./build/index.d.ts",
-      "default": "./build/index.module.js"
+      "default": "./build/index.mjs"
     }
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/lens/package.json b/packages/lens/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/logger/package.json b/packages/logger/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/npm-cookie-baker/package.json b/packages/npm-cookie-baker/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"

diff --git a/packages/npm-history/package.json b/packages/npm-history/package.json
@@ -8,10 +8,10 @@
   "exports": {
     "types": "./build/index.d.ts",
     "require": "./build/index.js",
-    "default": "./build/index.module.js"
+    "default": "./build/index.mjs"
   },
   "main": "build/index.js",
-  "module": "build/index.module.js",
+  "module": "build/index.mjs",
   "types": "build/index.d.ts",
   "browserslist": [
     "last 1 year"