Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.1 #277

Merged
merged 18 commits into from
Jan 27, 2020
Merged

V1.1 #277

merged 18 commits into from
Jan 27, 2020

Conversation

artalar
Copy link
Owner

@artalar artalar commented Jan 16, 2020

close #38
close #263
close #275
close #276
close #278

@artalar artalar requested a review from belozer January 16, 2020 05:53
docs/glossary.md Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
expect(store.getState(countAtom)).toBe(4)
expect(listener).toHaveBeenLastCalledWith(4)

store.dispatch({ ...initAction, payload: state })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... It seems a bit non-obvious, since "init" occurs twice in this way. Should I use a different name for the action? Or use a special API...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a private API, not described in docs

@artalar artalar mentioned this pull request Jan 18, 2020
docs/guides/IoC.md Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/debug/package.json Outdated Show resolved Hide resolved
packages/core/tests/index.test.ts Outdated Show resolved Hide resolved
docs/guides/IoC.md Outdated Show resolved Hide resolved
docs/guides/IoC.md Outdated Show resolved Hide resolved
packages/core/tests/index.test.ts Outdated Show resolved Hide resolved
packages/core/src/declareAtom.ts Outdated Show resolved Hide resolved
@artalar artalar merged commit 44ae893 into master Jan 27, 2020
@artalar artalar deleted the v1.1 branch January 27, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants