Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourcemap support #22

Closed
wants to merge 2 commits into from
Closed

Fix sourcemap support #22

wants to merge 2 commits into from

Conversation

billowz
Copy link

@billowz billowz commented Jun 18, 2019

Description

  • fix sourcemap
  • update dependencies
  • update readme.md

Related Issue

closes #21

Motivation and Context

the sourceMap option not work (#21)

How Has This Been Tested?

I have add a test to check the generated source map from rollup

@billowz billowz changed the title Fix sourceMap Fix sourceMap support Jun 18, 2019
@billowz billowz changed the title Fix sourceMap support Fix sourcemap support Jun 18, 2019
@benmccann
Copy link
Contributor

@artberri any change you'd be able to take a look at this PR?

@doppelganger9
Copy link

Hi,

This PR + a new published NPM version will help solving - in a clean way - this issue on another repository : bahmutov/coverage-example-svelte#1

In the meantime, we'll reference the rc branch from @billowz forked repo.
npm install --save-dev https://github.com/billowz/rollup-plugin-istanbul#rc

@niksy
Copy link

niksy commented Dec 17, 2020

What is the status of this PR? Can we get this merged?

@artberri
Copy link
Owner

I was a bit 'out' of this package, I'll try to review this during this week if possible.

@artberri artberri closed this Dec 22, 2020
@artberri artberri deleted the branch artberri:master December 22, 2020 22:05
@artberri
Copy link
Owner

Hi @billowz the new version 3.0.0 that I've already published in the npm registry should fix the bug.

The PR has been automatically closed because I changed the default branch name from master to main. Anyway, I didn't want to merge it because it was a bit outdated (my fault, of course). I don't think the extensions option is needed neither.

So, I've finally coded the fix myself based on your work. THANK YOU VERY MUCH FOR YOUR TIME.

/cc @niksy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source map not work
5 participants