Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu isnt opening in Firefox 26! #113

Closed
nikosrossolatos opened this issue Jan 1, 2014 · 23 comments
Closed

Menu isnt opening in Firefox 26! #113

nikosrossolatos opened this issue Jan 1, 2014 · 23 comments

Comments

@nikosrossolatos
Copy link

Hi.

i have implemented the sidr menu on my app. I can use it through my
windows phone 8, chrome latest , my android browser but in firefox 26 it just doesnt work.

It does work on http://www.berriart.com/sidr though, and if i copy paste the javascript file from there it works also.

So, anyone else can see it/propose changes? ! Thanks

@ghost
Copy link

ghost commented Jan 6, 2014

got the same problem

@eslam-mahmoud
Copy link

Same here, works on Firefox 26 Ubuntu but not windows8 FF 26

@eslam-mahmoud
Copy link

@artberri
The problem happened when i used firefox developer tool https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_View to resize the window ctrl+shift+m and used the simulate touch event button
it update the config to dom.w3c_touch_events.enabled;1 but does not return it back to 0

witch tell the plugin that it works on touch device
https://github.com/artberri/sidr/blob/master/src/jquery.sidr.js ----> line 289 ----> if('ontouchstart' in document.documentElement)

So the click event will never work !
But the demo site works in the same browser !!

@jambelly
Copy link

@eslam-mahmoud
I have had exactly the same problem with the developer tools after using the simulate touch button. I've even tried uninstalling and switching off the tools but the problem still exists.

I too have noticed that the demo site still works so there must be a fix for this this issue.

@platzhersh
Copy link

Same problem here. Demo Site is working, if I build something myself it doesn't work inf Firefox (V26)

@jambelly
Copy link

Fixed! I downloaded the latest unminified js from https://github.com/artberri/sidr and it all seems to work now.

@eslam-mahmoud
Copy link

@jambelly
Did not fix it for me, i tried both minified and expanded files and both the last commit was 3 months ago.

@imcarlosdev
Copy link

I have the same problem, is this still not resolved?

@geage
Copy link

geage commented Feb 17, 2014

@artberri

Tengo el mismo problema, sidr no funciona en mi prueba en firefox pero en el sitio de sidr si funciona en firefox

mi sitio funciona bien en IE y Chrome pero no en firefox
la pagina de sidr funciona en IE, Chrome and Firefox
entonces me pregunto donde estoy fallando?

probé el archivo min y el extendido
y siguió sin funcionar

entonces probé mi sitio reemplazando en jquery.sidr.min.js por el archivo min.js (http://www.berriart.com/sidr/javascripts/min.js) que está en la pagina de sidr y funcionó

así que por deduccion no funciona porque hay algo diferente entre la version de descarga y la usada en la pagina demo de sidr

por favor chequear esto

********** now in English with the help of "Google translate "

I have the same problem, sidr not work in firefox on my test site but if it works in firefox sidr

My site works fine in IE and Chrome but not in firefox
Sidr page works in IE, Chrome and Firefox
then I wonder where I'm going wrong?

I tried the file and the extended min
and continued to not work properly

then tried my site replacing "jquery.sidr.min.js" with the "min.js" file that is used on sidr demo page and it worked
that the file http://www.berriart.com/sidr/javascripts/min.js

so by deduction does not work because there is something different between the download version and the one used in the demo page sidr

please check this

@fedegonzaleznavarro
Copy link

+1

@ESasmaz
Copy link

ESasmaz commented Apr 21, 2014

+1

@RaspberryBlack
Copy link

Same problem here, any updates yet? There's a lot of stuff in the original js file mentioned above that belongs to the demo...

@RaspberryBlack
Copy link

Ok, I really needed this so here's my quickfix juts in case it helps anyone else... (not much of a fix but works for what I need; description in the readme):
https://github.com/RaspberryBlack/SidrDirtyfix/blob/master/jquery.sidr.js
Could this be fixed properly please?

@morales2k
Copy link

I still have this issue with latest FF as well...

@jambelly
Copy link

jambelly commented Jul 8, 2014

Strange. Sidr seems to work for me on http://www.coxlondon.com but not on http://www.veinteractive.com/ Does anyone have the same issue? Looking at both in FF 30.0

@morales2k
Copy link

This gist might help... It made it work for me on all modern browsers...
The gist has 2 'files'; the sidr script with an alteration and the forceclick option that made the magic for me... if it helps anyone else, then all the better!

@nadler
Copy link

nadler commented Jul 8, 2014

With FF 30 it seems to work for me on both http://www.coxlondon.com and
http://www.veinteractive.com/.

It also works on my own website without any issues that I can tell in FF 30.

On Tue, Jul 8, 2014 at 10:55 AM, jambelly notifications@github.com wrote:

Strange. Sidr seems to work for me on http://www.coxlondon.com but not on
http://www.veinteractive.com/ Does anyone have the same issue? Looking at
both in FF 30.0


Reply to this email directly or view it on GitHub
#113 (comment).

@morales2k
Copy link

It wasn't going my way with FF 30 (32bit FF, i don't know if there is 64bit FF exe - on windows 7 64bit)... but the gist I posted made it work.
jquery version I am using is 1.9.2...

I'm also loading twitter bootstrap and bxslider in my application... I am yet to see if it could be a script conflict, because when it fails to work, it just does nothing and there is no console output of any kind. It just doesn't work...

@englishextra
Copy link

the URL of this gist

@morales2k
Copy link

had it posted on the previous msg i sent... but for simplicity, here it is again

a colleague passed it on to me and it worked like a charm... I decided to post it here so everyone can help themselves onto it ... in case it fixes the issue for anyone else as well...

@englishextra
Copy link

try this sidr and see what happens in thandem with bxslider which is tricky plugin and bootstrap

//cdn.jsdelivr.net/jquery.sidr/1.1.1/jquery.sidr.js

@onetrev
Copy link

onetrev commented Aug 15, 2014

Confirmed! @jlmorales your gist worked perfectly. Should you maybe submit a pull request for this if possible? Assuming of course development is still going on this plugin, which I hope it is because it's popular and awesome!

@artberri
Copy link
Owner

artberri commented Jan 9, 2016

Preparing a new version with a fix for this https://github.com/artberri/sidr/tree/reborn

@artberri artberri closed this as completed Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests