Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid value for the "X poison damage over Y seconds" attribute #3

Open
artcom-net opened this issue Oct 7, 2020 · 3 comments
Open

Invalid value for the "X poison damage over Y seconds" attribute #3

artcom-net opened this issue Oct 7, 2020 · 3 comments
Assignees
@artcom-net
Labels
bug Something isn't working fixed_in_dev This issue was fixed in the dev branch

Comments

@artcom-net
Copy link
Owner

artcom-net commented Oct 7, 2020 •
edited

Attribute id = 57.
now: Adds 205-205 Poison Damage over 125 Seconds
expected: 100 poison damage over 5 seconds
@artcom-net artcom-net added the bug Something isn't working label Oct 7, 2020
@artcom-net artcom-net self-assigned this Oct 7, 2020
@artcom-net artcom-net changed the title Invalid value for the "X poison damage over Y Seconds" attribute Invalid value for the "X poison damage over Y seconds" attribute Oct 7, 2020
@artcom-net
Copy link
Owner Author

I don't know how to parse it yet.

@artcom-net artcom-net added the help wanted Extra attention is needed label Oct 9, 2020
@artcom-net
Copy link
Owner Author

I think I found a divisor for the damage and duration values:

  • 25 is a divisor for the duration as a result we get the count of seconds;
  • 10.25 is a divisor of the source damage value as a result we get damage per second;
  • the final formula looks like this: damage_value = round((source_damage / 10.25) * (source_duration / 25)) .

@artcom-net artcom-net added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Oct 14, 2020
@artcom-net
Copy link
Owner Author

artcom-net commented Oct 15, 2020 •
edited

After long testing, I found a more accurate divisor factor for calculating damage per second: 10.24.

@artcom-net artcom-net removed the help wanted Extra attention is needed label Oct 15, 2020
artcom-net added a commit that referenced this issue Oct 15, 2020
@artcom-net
#3 Fix parsing of the "X poison damage over Y seconds" attribute
d0d227f 
- fixed damage calculation;
- fixed duration calculation;
- if the minimum damage is equal to the maximum, then a template "+X poison damage over Y seconds" is used, otherwise "Adds X-Y poison damage over Z seconds".
@artcom-net artcom-net added the fixed_in_dev This issue was fixed in the dev branch label Oct 15, 2020
@artcom-net artcom-net mentioned this issue Oct 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artcom-net artcom-net

Labels
bug Something isn't working fixed_in_dev This issue was fixed in the dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artcom-net