Disable URL connection caching in SPIClassIterator (elastic#88586)

arteam · Jul 22, 2022 · 233e391 · 233e391
1 parent 78ccd47
commit 233e391
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/docs/changelog/88586.yaml b/docs/changelog/88586.yaml
@@ -0,0 +1,6 @@
+pr: 88586
+summary: Disable URL connection caching in SPIClassIterator
+area: Infra/Plugins
+type: bug
+issues:
+ - 88275
diff --git a/server/src/main/java/org/elasticsearch/plugins/spi/SPIClassIterator.java b/server/src/main/java/org/elasticsearch/plugins/spi/SPIClassIterator.java
@@ -26,6 +26,7 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.net.URL;
+import java.net.URLConnection;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -106,7 +107,9 @@ private boolean loadNextProfile() {
             }
             final URL url = profilesEnum.nextElement();
             try {
-                final InputStream in = url.openStream();
+                URLConnection urlc = url.openConnection();
+                urlc.setUseCaches(false); // prevents retaining a handle to the underlying jar file, when the stream is closed
+                final InputStream in = urlc.getInputStream();
                 boolean success = false;
                 try {
                     final BufferedReader reader = new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8));