Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PREMIS rights #63

Merged
merged 2 commits into from
Mar 24, 2019
Merged

Add support for PREMIS rights #63

merged 2 commits into from
Mar 24, 2019

Conversation

sevein
Copy link
Member

@sevein sevein commented Mar 23, 2019

@sevein sevein self-assigned this Mar 23, 2019
@sevein sevein requested a review from cole March 23, 2019 21:11
@sevein sevein force-pushed the dev/premis-rights branch 4 times, most recently from 1daede3 to d9f3e2f Compare March 23, 2019 21:47
cole
cole approved these changes Mar 24, 2019
View reviewed changes
Copy link
Contributor

@cole cole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, this looks great! I noted a few style nitpicks, feel free to leave them if you prefer.

metsrw/fsentry.py Outdated Show resolved Hide resolved
tests/plugins/premisrw/test_premis.py Outdated Show resolved Hide resolved
tests/test_mets.py Outdated Show resolved Hide resolved
@sevein sevein merged commit 9623688 into master Mar 24, 2019
@sevein sevein deleted the dev/premis-rights branch March 24, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole cole cole approved these changes

Assignees

@sevein sevein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sevein @cole