Fix access to elements with clashing tags #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
force-pushed
the
dev/fix-clashing-element-tags-issue
branch
from
1a395cc
to
ad9b3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
premisrw couldn't handle access to attributes when the schema used the same attribute name in more than one element, e.g.
startDateandendDateare values used multiple times underPREMISRights. This pull request solves the problem by introducing alternative keys qualified with the path to the value instead, e.g.foo__bar__start_dateinstead ofstart_datewhen there is a clash.Also, added some missing role attributes to the
PREMISRightsschema.Connects to archivematica/Issues#446.