Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a mechanism to provide a custom FILEID #71

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

ross-spencer
Copy link
Contributor

@ross-spencer ross-spencer commented Jun 7, 2019

Enable mets-reader-writer to output a FILEID for a METS document that
isn't automatically generated using another component provided to the
FSENTRY constructor.

Connected to archivematica/Issues#660
Required by artefactual/archivematica-storage-service#467

@ross-spencer ross-spencer force-pushed the dev/issue-660-enable-use-of-fileid branch from 142fa79 to 9931ae5 Compare June 9, 2019 20:35
@ross-spencer ross-spencer changed the title wip WIP: Create a mechanism to provide a custom FILEID Jun 9, 2019
@ross-spencer ross-spencer requested review from cole and sevein June 13, 2019 08:33
@ross-spencer ross-spencer changed the title WIP: Create a mechanism to provide a custom FILEID Create a mechanism to provide a custom FILEID Jun 13, 2019
@ross-spencer ross-spencer self-assigned this Jun 13, 2019
Copy link
Contributor

@cole cole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that could lead to confusion here is the similarity between FSEntry.fileid (the new attribute) and FSEntry.file_id (the property). What about using _fileid for the new one, to communicate that the property should be used for access?

Otherwise this looks good.

@ross-spencer
Copy link
Contributor Author

I hadn't even hit re-reivew!! 😄 though I appreciate it! Thanks @cole will get this merged and published today and finalize subsequent changes to the Storage Service.

Enable mets-reader-writer to output a FILEID for a METS document that
isn't automatically generated using another component provided to the
FSENTRY constructor.
@ross-spencer ross-spencer force-pushed the dev/issue-660-enable-use-of-fileid branch from d31a277 to 9ab6410 Compare June 21, 2019 14:45
@ross-spencer ross-spencer merged commit 9ab6410 into master Jun 21, 2019
@ross-spencer ross-spencer deleted the dev/issue-660-enable-use-of-fileid branch June 21, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants