Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide mechanism to check distribution config #74

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

ross-spencer
Copy link
Contributor

@ross-spencer ross-spencer commented Aug 22, 2019

Adds a package-check command to make sure the package description for pypi is valid.

Both new combinations of make recipe work as anticipated:

twine check dist/*
Checking distribution dist/metsrw-0.3.12-py2.py3-none-any.whl: Passed
Checking distribution dist/metsrw-0.3.12.tar.gz: Passed
twine upload dist/* --repository-url https://upload.pypi.org/legacy/
Enter your username:

Connected to archivematica/Issues#875

Copy link
Contributor

@cole cole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just the failing CI checks to take care of. Black wants double quotes for strings. I'll approve, and if you can fix the linting failure before merging that'd be grand.

It looks like the other failure is we don't have a pinned version of lxml and they have dropped 3.4 support. I think to solve that we should probably drop 3.4 support (it's no longer supported), but we can also avoid future failures like this by pinning the versions. That is a separate issue though, and I feel like this PR can be merged without passing that check.

@ross-spencer ross-spencer force-pushed the dev/issue-875-correct-package-formatting branch from e6fbf22 to 58c4292 Compare August 23, 2019 16:47
@ross-spencer ross-spencer merged commit 58c4292 into master Aug 23, 2019
@ross-spencer ross-spencer deleted the dev/issue-875-correct-package-formatting branch August 23, 2019 16:52
@ross-spencer
Copy link
Contributor Author

ross-spencer commented Aug 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants