Fixes and infrastructure support #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| resource.is_authenticated(request) | ||
| resource.throttle_check(request) | ||
|
|
||
| # Get object |
There was a problem hiding this comment.
I definitely like standardizing this.
All buttons have class 'btn' on them, so they are styled by bootstrap, instead of being browser default. Submit and related 'default' actions are 'btn-primary' (colored blue).
We have several custom endpoints that implement the same boilerplate logic. Add a decorator that implements that, such as checking allowed methods, authentication, fetching the detail resource, deserializing the body and providing it to the endpoint as a bundle.
Custom endpoints should use new decorator to reduce boilerplate code and return useful errors if the requested object doesn't exist.
Extract_file now takes an optional extract path which defaults to a temp directory, and omitting the relative path extracts the whole package.
Misc fixes: rename PACKAGE_TYPE_[EXTRACTABLE|DELETABLE] to PACKAGE_TYPE_CAN_[EXTRACT|DELETE] to make easier to extend with other categories. Import locations.forms module, instead of each form separately, so it is easier to add new forms, similarly for models in forms.py
Package has JSONField that stores misc attributes than need to be tracked, but are not common enough to deserve their own fields. Update migration.
|
💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes/updates that are useful to multiple dev branches.