Add Arkivum #39
Merged
Add Arkivum #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
abd79bd
to
97383cd
Compare
| def browse(self, path): | ||
| # Support browse so that the Location select works | ||
| if self.remote_user and self.remote_name: | ||
| return self.space._browse_ssh(path, self.remote_user, self.remote_name) |
There was a problem hiding this comment.
What's the difference between these two options?
There was a problem hiding this comment.
Arkivum exports a CIFS share that is where the files show up as local filesystem. We'd originally discussed having that mount be either local or remote - remote_user and remote_name will be populated if the mount is remote with the ssh username & host. Alternately, we could just SSH in to the Arkivum server that provides the fake FS.
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
97383cd
to
9aa73d2
Compare
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
9aa73d2
to
65b79a7
Compare
| # Can this be done by just deleting the file on disk? | ||
| # TODO folders | ||
| url = 'https://' + self.host + '/files/' + delete_path | ||
| print 'url', url |
There was a problem hiding this comment.
Convert this into logging calls, if you want to keep it?
|
👍 aside from comments |
|
This branch has been tested with an A-Stor appliance and is working properly. I think this is ready to merge into qa/1.x |
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
65b79a7
to
8fb738a
Compare
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
8fb738a
to
3d65682
Compare
|
👍 |
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
3d65682
to
58184dd
Compare
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
58184dd
to
07c7254
Compare
refs #7188
refs #7188
refs #7188
refs #7188
refs #7188
refs #7188
refs #7188 Creating a Location has a browse option for a Space. Arkivum may use browsing over SSH, so move that to the Space for Arkivum and pipeline local FS.
refs #7188
qubot
force-pushed
the
dev/issue-7188-arkivum
branch
from
1b61548
to
22c770a
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Arkivum as a Space.
Also, update
post_move_from_storage_serviceto do the same path munging thatmove_from_storage_servicedoes, and move deleting the staging copy to afterpost_move_from_storage_serviceruns.This requires #38