Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: archivematicaClient.py passes unexpected capture_output kwarg #1076

Closed
jrwdunham opened this issue May 2, 2018 · 1 comment
Closed

Problem: archivematicaClient.py passes unexpected capture_output kwarg #1076

jrwdunham opened this issue May 2, 2018 · 1 comment
Assignees
@jrwdunham
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.

Comments

@jrwdunham
Copy link
Contributor

Commit f527d53 added this call:

executeOrRun('command', script, stdIn='', printing=True, capture_output=capture_output)

The problem is that executeOrRun does not recognize the capture_output kwarg, which is currently only available in dev/1.8.x.
@jrwdunham jrwdunham mentioned this issue May 2, 2018
Closed
@jrwdunham jrwdunham self-assigned this May 2, 2018
@jrwdunham jrwdunham added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label May 2, 2018
@jrwdunham jrwdunham added this to the 1.7.1 milestone May 2, 2018
@jrwdunham jrwdunham mentioned this issue May 2, 2018
Closed
@jrwdunham jrwdunham added Status: in progress Issue that is currently being worked on. Waffle label. Columbia University Library CUL: phase 2 labels May 2, 2018
@jrwdunham jrwdunham mentioned this issue May 4, 2018
Merged
@jrwdunham jrwdunham removed this from the 1.7.1 milestone May 4, 2018
@jrwdunham
Copy link
Contributor Author

Closing this because the new #1078 brings in the archivematicaClient.py refactor without ever introducing this issue. See the description of that PR.

@jrwdunham jrwdunham removed Status: in progress Issue that is currently being worked on. Waffle label. CUL: phase 2 Columbia University Library labels May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrwdunham jrwdunham

Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrwdunham