Add ability to customize LDAP Attributes #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misilot
force-pushed
the
ldap-attributes
branch
3 times, most recently
from
30f4f6e
to
2a2059b
Compare
There was a problem hiding this comment.
Thanks @misilot! This looks good to me. I only left one suggestion. Could you please target the qa/1.x branch for your pull request?
misilot
force-pushed
the
ldap-attributes
branch
from
2a2059b
to
65aebdd
Compare
misilot
force-pushed
the
ldap-attributes
branch
from
65aebdd
to
aa633b0
Compare
|
Thanks @replaceafill, I removed the extra commas, and renamed the attributes. It's also targeting qa/1.x now |
|
Thank you @misilot. I started executing the CI checks on the PR. I also noticed this is your first contribution. Congrats! Could you please sign and send the Contributor's Agreement before we merge? |
replaceafill
added
AMAUAT
|
@replaceafill, I just sent it in, sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to override the attributes for first name, last name, and email.
I tested this locally, and it works, and would be great to not have to overwrite core files on the system.
Thanks!
Related to archivematica/Issues#1565