Micro-optimisations from the Wellcome fork #1808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @alexwlchan. This looks good. Could you please target the |
* We run `if file_type in DERIVATIVE_TYPES` when we first validate;
checking for set inclusion is faster than a tuple -- O(1), not O(n).
In practice it's unlikely to make a noticeable difference for a
collection of two elements, but it sets precedent for elsewhere.
* Rather than accumulating the results of _execute_rule_command() in a
list, inspect them one-by-one.
This won't have any effect on a file that passes validation, but if
a file fails validation it'll exit on the first failure, and skip
running unnecessary checks.
We've already looked up the PREMIS object on L61; we don't gain anything from retrieving it again.
alexwlchan
force-pushed
the
wellcome-fork-remainders
branch
from
a6156be
to
d3d664f
Compare
Done! |
replaceafill
added
the
AMAUAT
|
Thank you @alexwlchan! I rebased your branch on top of the current |
replaceafill
removed
the
AMAUAT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of archivematica/Issues#1578
I've been reviewing the changes in our fork of artefactual/archivematica. After removing changes that are already merged (OIDC/zipped bag) or changes which won't be merged (Wellcome-specific bits), this is what was left. It's not especially substantial, but seemed a shame to let it go to waste.