Fix "sphinx-build test" errors #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djjuhasz
force-pushed
the
dev/fix-build-warnings
branch
2 times, most recently
from
d16b75a
to
3e9923d
Compare
`sphinx-build test` throws an error in Sphinx v5 because the extlinks definitions don't include an explicit %s character in the "caption". - Add a local "links/" directory and "link.py" file for extlink definitions - Update extlink "captions" to include a "%s" placeholder - Update config.py to use local extlink definitions - Update conf.py and .gitignore to ignore a venv ".env" directory - Add ".vscode" and "__pycache__ dirs to .gitignore - Cosmetic: reformatted conf.py with black
djjuhasz
force-pushed
the
dev/fix-build-warnings
branch
2 times, most recently
from
42f1a6b
to
1d0a1be
Compare
|
@djjuhasz I just added a new definition to extlinks for AtoM Github issues but the rest looks good to me! The test does still fail since it looks like we have a bunch of undefined labels in the repo, but I confirmed that this fix works and the test passes once those labels are fixed. Will make a PR to fix those labels shortly. |
|
@anvit great! If you approved the PR, I'll merge it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sphinx-build testthrows an error in Sphinx v5 because the extlinksdefinitions don't include an explicit %s character in the "caption".
definitions