Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: settings to enable or disable tooltips do not work in BS5 templates #1777

Closed
fiver-watson opened this issue Mar 15, 2024 · 0 comments · Fixed by #1780
Closed

Problem: settings to enable or disable tooltips do not work in BS5 templates #1777

fiver-watson opened this issue Mar 15, 2024 · 0 comments · Fixed by #1780
Assignees
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone

Comments

@fiver-watson
Copy link
Contributor

Current Behavior

Noticed during a client training workshop yesterday.

Steps to reproduce the behavior

  1. Ensure that you are using the BS5 templates
  2. Navigate to Admin > Settings > Global > Presentation, set "Show Tooltips" to no, and save
  3. Navigate to Add > Archival description and inspect the resulting empty edit template

Error encountered

Because tooltips no longer appear in a JS popup beside the main body column of the edit page (in the BS5 templates, they appear directly under the edit field), the current setting to hide them does nothing. The tooltips are still visible in the edit page after changing the setting.

Expected Behavior

When the setting to show tootlips is set to "no," tooltips are not shown.

Possible Solution

If the changes to the template layout make it hard or impossible to fix the expected setting behavior, one alternative would be to simply remove the setting.

Context and Notes

No response

Version used

2.8.1 - 193

Operating System and version

Docker env

Default installation culture

en

PHP version

PHP 7.4

Contact details

No response

@fiver-watson fiver-watson added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Mar 15, 2024
@melaniekung melaniekung self-assigned this Mar 19, 2024
melaniekung added a commit that referenced this issue Mar 20, 2024
@melaniekung melaniekung linked a pull request Mar 20, 2024 that will close this issue
melaniekung added a commit that referenced this issue Apr 1, 2024
melaniekung added a commit that referenced this issue Apr 1, 2024
melaniekung added a commit that referenced this issue Apr 2, 2024
melaniekung added a commit that referenced this issue Apr 2, 2024
melaniekung added a commit that referenced this issue Apr 2, 2024
melaniekung added a commit that referenced this issue Apr 2, 2024
@anvit anvit added this to the 2.9.0 milestone Apr 12, 2024
@anvit anvit self-assigned this Apr 12, 2024
anvit pushed a commit that referenced this issue May 16, 2024
Move tooltip functionality to js for BS5.
Force cypress to type to bypass tooltip
anvit pushed a commit that referenced this issue May 16, 2024
Move tooltip functionality to js for BS5.
Force cypress to type to bypass tooltip
anvit pushed a commit that referenced this issue May 17, 2024
Move tooltip functionality to js for BS5.
Force cypress to type to bypass tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants