-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change initial letter of languages to uppercase in menu, refs #13515 #1302
Change initial letter of languages to uppercase in menu, refs #13515 #1302
Conversation
Thanks @mInnes-archives, @fiver-watson, would you mind giving it a try to this and create a ticket? |
Thanks @mInnes-archives . Excellent! |
Redmine issue ticket created here: https://projects.artefactual.com/issues/13515 |
Thanks @mInnes-archives! Just a couple of things ... I wonder why did you revert the change in the settings page, the ticket doesn't mention that but I think it may also be a good addition (@fiver-watson, thoughts?). And, we just merged another PR so if you could rebase we could merge with |
Yes, I really should have explained that. That commit added uppercasing in the settings menu, which in isolation is a fine idea. However, since the settings menu has both the table with the list of active languages and the select form underneath for adding new languages, I was actually introducing some inconsistency. The main issue being that there isn't an easy way to change the casing on the choices of the select form. So you had initial uppercasing above but below it was back to lowercasing. Given that the spirit of the original issue was about consistency, I felt it best to keep the settings menu consistent within itself. The settings menu also wasn't as much of an issue as the top bar menu, since you aren't displaying information using different i18n cultures side-by-side. It also isn't public facing.
I will do this later. I'm just away from my dev space at the moment. |
Initial letters of language names in the language menu are now uppercase to allow for consistency across i18n cultures.
Good to go now. |
Thanks @mInnes-archives! |
PR is in response to open issue #1128 regarding inconsistency in upper/lower casing of initial letter for languages in the language menu
and the language settings menu. Based on the assumption that language names written as a single word in a menu should probably start uppercased, it is now consistently uppercase.If this is still an issue open for a bit of debate, that's cool, but this PR should at least provide an easy solution for those wishing for the consistency without modifying vendor files.