Change initial letter of languages to uppercase in menu, refs #13515

[mInnes-archives]

PR is in response to open issue #1128 regarding inconsistency in upper/lower casing of initial letter for languages in the language menu and the language settings menu. Based on the assumption that language names written as a single word in a menu should probably start uppercased, it is now consistently uppercase.

If this is still an issue open for a bit of debate, that's cool, but this PR should at least provide an easy solution for those wishing for the consistency without modifying vendor files.

[jraddaoui]

Thanks @mInnes-archives,

@fiver-watson, would you mind giving it a try to this and create a ticket?

[ricardodepinho]

Thanks @mInnes-archives . Excellent!
I will give it a try ASAP.
Cheers

[fiver-watson]

I've tested this, and as far as I'm able to tell, it doesn't seem to be negatively impacting non-latin characters. I think it looks good!

[fiver-watson]

Redmine issue ticket created here: https://projects.artefactual.com/issues/13515

[jraddaoui]

Thanks @mInnes-archives! Just a couple of things ...

I wonder why did you revert the change in the settings page, the ticket doesn't mention that but I think it may also be a good addition (@fiver-watson, thoughts?). And, we just merged another PR so if you could rebase we could merge with --ff-only without adding myself to the commit.

[mInnes-archives]

I wonder why did you revert the change in the settings page, the ticket doesn't mention that but I think it may also be a good addition (@fiver-watson, thoughts?).

Yes, I really should have explained that. That commit added uppercasing in the settings menu, which in isolation is a fine idea. However, since the settings menu has both the table with the list of active languages and the select form underneath for adding new languages, I was actually introducing some inconsistency. The main issue being that there isn't an easy way to change the casing on the choices of the select form. So you had initial uppercasing above but below it was back to lowercasing. Given that the spirit of the original issue was about consistency, I felt it best to keep the settings menu consistent within itself. The settings menu also wasn't as much of an issue as the top bar menu, since you aren't displaying information using different i18n cultures side-by-side. It also isn't public facing.

And, we just merged another PR so if you could rebase we could merge with --ff-only without adding myself to the commit.

I will do this later. I'm just away from my dev space at the moment.

[mInnes-archives]

Good to go now.

[jraddaoui]

Thanks @mInnes-archives!