Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-line i18n strings #1704

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

anvit
Copy link
Contributor

@anvit anvit commented Nov 6, 2023

Join i18n strings that have been split into multiple lines to have them be recognized as a single unit for translations.

@anvit anvit added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Nov 6, 2023
@anvit anvit added this to the 2.8.0 milestone Nov 6, 2023
@anvit anvit requested a review from a team November 6, 2023 22:54
@anvit anvit self-assigned this Nov 6, 2023
@anvit anvit requested a review from sbreker November 6, 2023 22:55
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anvit! This had to be a pain, sorry I didn't realize when we introduced the code formatter. It also went under the radar for a long time!

@anvit
Copy link
Contributor Author

anvit commented Nov 7, 2023

@jraddaoui No problem! To be honest it wasn't as bad as I thought it was going to be, because when I'd ran a pattern-match search, I found over 700 results 😅, but a lot of those turned out to be SQL statements that were split up, CLI exceptions, and other such results that don't affect the user.

Join i18n strings that have been split into multiple lines to have them
be recognized as a single unit for translations.
@anvit anvit force-pushed the dev/issue-split-translator-strings branch from ca13903 to 6cb1412 Compare November 7, 2023 18:19
@anvit anvit merged commit 6cb1412 into qa/2.x Nov 7, 2023
@anvit anvit deleted the dev/issue-split-translator-strings branch November 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants