Improve ES search for archival descriptions, #10082 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 15, 2016 16:17
When searching for information objects, now only fields that make sense will be included in our ES _all queries. So now doing information object searches will no longer yield results if the text matches irrelevant fields such as repository history, creator slugs, etc.
Add sort by reference so we can see results ordered based on their ES scores. Also tweaked the boost power of creator name to account for creators also automatically get added to name access points and that was making the score higher than expected.
For information object searches, the default operator will now be AND instead of OR.
| @@ -439,6 +459,39 @@ protected static function getAllObjectStringFields($rootIndexType, $object, $pre | |||
| return $fields; | |||
| } | |||
|
|
|||
| public static function addBoostValuesToFields(&$fields, $i18nFields, $nonI18nFields) | |||
There was a problem hiding this comment.
Shouldn't this method belong to arElasticSearchModelBase?
|
Looking great! Just one small observation about the location of the |
|
squashed&merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR attempts to accomplish 3 things: