Add creator field to advanced search, refs #12140 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraddaoui
reviewed
May 24, 2018
There was a problem hiding this comment.
Hi @mcantelon,
This looks great. But we've recently added the inherited creators to the search index and I wonder if this should be querying over both. @fiver-watson, what do you think?
|
I've updated the PR to include inherited creators... thanks! |
jraddaoui
approved these changes
May 25, 2018
Added ability to search by creator to advanced search.
qubot
force-pushed
the
dev/issue-12140-creator-search
branch
2 times, most recently
from
5a6fa00
to
3f93a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to search by creator to advanced search.