Fix deaccession deletion issue, refs #12460 #871
Conversation
| @@ -45,8 +45,6 @@ public function save($connection = null) | |||
|
|
|||
| public function delete($connection = null) | |||
| { | |||
| QubitSearch::getInstance()->delete($this->accession); | |||
There was a problem hiding this comment.
If we are updating the index when we save/add an accession, then will we need to also '->update' on a delete? Or is the '->update' in save() not necessary either?
There was a problem hiding this comment.
I did some testing and looked at the code and it seems like the parent accession's document exists independently of whether or not there's a deaccession so I've removed both of the ElasticSearch alterations.
There was a problem hiding this comment.
(I've gotten rid of the update in the save because of this.)
| @@ -45,8 +45,6 @@ public function save($connection = null) | |||
|
|
|||
| public function delete($connection = null) | |||
| { | |||
| QubitSearch::getInstance()->delete($this->accession); | |||
There was a problem hiding this comment.
I did some testing and looked at the code and it seems like the parent accession's document exists independently of whether or not there's a deaccession so I've removed both of the ElasticSearch alterations.
| @@ -45,8 +45,6 @@ public function save($connection = null) | |||
|
|
|||
| public function delete($connection = null) | |||
| { | |||
| QubitSearch::getInstance()->delete($this->accession); | |||
There was a problem hiding this comment.
(I've gotten rid of the update in the save because of this.)
There was a problem hiding this comment.
Looks great @mcantelon! Thanks for looking at that ->update() method!
|
Thanks @sbreker! |
qubot
force-pushed
the
dev/issue-12460-deaccession-deletion-fix
branch
from
16444f3
to
3beb188
Compare
Fixed issue where deleting a deaccession would remove the accession/accural related to it from the search index.
qubot
force-pushed
the
dev/issue-12460-deaccession-deletion-fix
branch
from
3beb188
to
830814b
Compare
Fixed issue where deleting a deaccession would remove the
accession/accural related to it from the search index.