Get raw parameters in filter tags, refs #13131 #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djjuhasz
reviewed
Aug 6, 2019
There was a problem hiding this comment.
@jraddaoui doesn't using $sf_data->getRaw('getParams') mean that any user data sent in a GET will be included in the resulting URL, without any sanitization? Maybe we need to manually do HTML escaping on the array values before outputting the URL?
|
Great point @djjuhasz! We have to be really careful after un-escaping and in any case, as the escaping strategy may be disabled to enable Markdown. I couldn't find where in the code so I tested it and it looks like |
When the escaping strategy is enabled and Markdown support is disabled, `getParams` is converted to a `sfOutputEscaperArrayDecorator` instance. This needs to be converted back using `$sf_data->getRaw()` to be able to merge it with another array in the template.
qubot
force-pushed
the
dev/issue-13131-escaping
branch
from
c2d2caa
to
55af3f9
Compare
|
c1e9b3c in stable/2.5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the escaping strategy is enabled and Markdown support is disabled,
getParamsis converted to asfOutputEscaperArrayDecoratorinstance.This needs to be converted back using
$sf_data->getRaw()to be ableto merge it with another array in the template.