Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arDominionPlugin theme header, refs #13137 #947

Merged
merged 1 commit into from Aug 7, 2019

Conversation

jraddaoui
Copy link
Contributor

Make sure the content of the site header is always wrapped within it.
Use a pseudo element and clearance to avoid disrupting themes extending
this one. This also makes the header play nicer with logos higher than
50px and long titles, fixing #3895 and #6293 too.

Make sure the content of the site header is always wrapped within it.
Use a pseudo element and clearance to avoid disrupting themes extending
this one. This also makes the header play nicer with logos higher than
50px and long titles, fixing #3895 and #6293 too.
@jraddaoui jraddaoui self-assigned this Aug 7, 2019
Copy link
Member

@mcantelon mcantelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@qubot qubot merged commit 635bf5f into qa/2.6.x Aug 7, 2019
@qubot qubot deleted the dev/issue-13137-header branch August 7, 2019 18:34
@jraddaoui
Copy link
Contributor Author

Thanks @mcantelon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants