Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library includes outside the "include" folder #78

Closed
LeoPizzo1 opened this issue Apr 21, 2022 · 2 comments
Closed

Library includes outside the "include" folder #78

LeoPizzo1 opened this issue Apr 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@LeoPizzo1
Copy link

All source files located outside "\include" folder are referring to the library without explicitly set the relative path (it expects that "cdt.h" it is in the include search path).
This forces to add the incldue folder as additional include directory (I'm using vs2019).

I think it is better to use the relative path to keep consistent with the installation.

I.e. in CDT\extras\InitializeWithGrid.h replace

#include "CDT.h"
#include "CDTUtils.h"

with

#include "../include/CDT.h"
#include "../include/CDTUtils.h"

In case it is wanted, I think it is better to use the <> instead of the "" to clarify that the included file must be available at the root of the search path.

#include <CDT.h>
#include <CDTUtils.h>
artem-ogre added a commit that referenced this issue Apr 25, 2022
@artem-ogre
Copy link
Owner

artem-ogre commented Apr 25, 2022

Thanks for reporting the issue!
Please check if the fixes in the branch are sufficient.

@LeoPizzo1
Copy link
Author

Great, for the uses I can test it seems perfect!

artem-ogre added a commit that referenced this issue Apr 26, 2022
@artem-ogre artem-ogre added the enhancement New feature or request label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants