Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard defines to PREDICATES_FAST_FMA check #136

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

here-abarany
Copy link
Contributor

Should allow for fast FMA on non-x86 architectures, most notably ARM.

Should allow for fast FMA on non-x86 architectures, most notably ARM.
@artem-ogre
Copy link
Owner

artem-ogre commented Sep 7, 2023

Hi, @here-abarany,

Thanks for the pull request, it looks good from a quick glance. I will double-check, read the docs, and merge it soon.

I have a couple of curiosity questions:

  • Do you have cases when you actually notice any performance difference with/without FMA? Or it's just something you randomly stumbled upon?
  • I am really curious if CDT is used for anything at heremaps?

@here-abarany
Copy link
Contributor Author

To answer your questions:

  1. This is something I stumbled upon when trying to debug an issue we encountered when running in the cloud. (AWS Graviton 3 instances) It turned out to not be the problem, it was related to some bad inputs caused by a bug on our side, but figured it was still worth submitting.
  2. Yes, I am working on a 3D map product and we are using CDT to triangulate our terrain.

@artem-ogre artem-ogre merged commit 419e370 into artem-ogre:master Sep 7, 2023
@artem-ogre
Copy link
Owner

Thanks again for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants