Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readinessProbe.sh-script fails silently #79

Closed
aboucham opened this issue Oct 9, 2023 · 1 comment · Fixed by #80
Closed

readinessProbe.sh-script fails silently #79

aboucham opened this issue Oct 9, 2023 · 1 comment · Fixed by #80
Assignees
@RoddieKieley
Labels
bug Something isn't working

Comments

@aboucham
Copy link
Contributor

aboucham commented Oct 9, 2023

Describe the bug
The problem is that when the scripts fetch an empty list from /proc/net/tcp and since it doesn't get an exception it won't fetch /proc/net/tcp6 where the ports are really are. It then doesn't find any open ports.

The problem here is that the value-variable is not stripped before it is split. This results in all ports equals None and then it will always continue - no matter whether the ports are listening or not.
@aboucham aboucham added the bug Something isn't working label Oct 9, 2023
aboucham added a commit to aboucham/activemq-artemis-broker-kubernetes-image that referenced this issue Oct 9, 2023
@aboucham
[artemiscloud#79] readinessProbe.sh-script fails
5fefca8 
Fix the readinessProbe.sh-script issue.
@aboucham
Copy link
Contributor Author

aboucham commented Oct 9, 2023

#80

aboucham added a commit to aboucham/activemq-artemis-broker-kubernetes-image that referenced this issue Oct 9, 2023
@aboucham
[artemiscloud#79] readinessProbe.sh-script fails
5882841 
Fix the readinessProbe.sh-script issue.
gaohoward pushed a commit that referenced this issue Oct 9, 2023
@aboucham @gaohoward
[#79] readinessProbe.sh-script fails
aee9eab 
Fix the readinessProbe.sh-script issue.
gaohoward pushed a commit that referenced this issue Oct 9, 2023
@aboucham @gaohoward
[#79] readinessProbe.sh-script fails
d5bb905 
Fix the readinessProbe.sh-script issue.
@gaohoward gaohoward linked a pull request Oct 9, 2023 that will close this issue
[#79] readinessProbe.sh-script fails #80
Merged
@aboucham aboucham changed the title readinessProbe.sh-script fails readinessProbe.sh-script fails silently Oct 9, 2023
rh-messaging-ci pushed a commit to rh-messaging/activemq-artemis-broker-kubernetes-image that referenced this issue Nov 28, 2023
@aboucham @brusdev
[artemiscloud#79] readinessProbe.sh-script fails
5e487a7 
Fix the readinessProbe.sh-script issue.
(cherry picked from commit aee9eab)

downstream: ENTMQBR-8476
rh-messaging-ci pushed a commit to rh-messaging/activemq-artemis-broker-kubernetes-image that referenced this issue Nov 28, 2023
@aboucham @brusdev
[artemiscloud#79] readinessProbe.sh-script fails
7cc8110 
Fix the readinessProbe.sh-script issue.
(cherry picked from commit d5bb905)

downstream: ENTMQBR-8476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RoddieKieley RoddieKieley

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#79] readinessProbe.sh-script fails aboucham/activemq-artemis-broker-kubernetes-image
3 participants
@gaohoward @RoddieKieley @aboucham