core: Limit the # of completion candidates returned per request + mark response (in)complete when necessary #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k response (in)complete when necessary Now the server returns at most 50 candidates. The response is marked as incomplete when the # is exactly 50, otherwise it's marked complete and the client doesn't need to issue any additional requests.
|
Hi there @artempyanykh, I wonder would it be possible to allow users to configure the candidate amount limits. My project contains a lot of markdown files (e.g., a daily journal dir) so the limit makes the suggestion incomplete all the time. |
|
Hi @narutohahahaha! Yeah, sounds reasonable to me. Could you file an issues with a feature request please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the server returns at most 50 candidates. The response is marked as incomplete when the # is exactly 50, otherwise it's marked complete and the client doesn't need to issue any additional requests.