Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README re: Helix editor configuration #97

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

ngraham20
Copy link
Contributor

@ngraham20 ngraham20 commented Oct 10, 2022

helix#4399 was merged. After installing the marksman binary, markdown worked in Helix as expected.

@ngraham20 ngraham20 changed the title Removed Helix Editor Configuration Removed Helix Editor Configuration from README Oct 10, 2022
@ngraham20
Copy link
Contributor Author

If accepted, I would love to get this PR labeled "hacktoberfest-approved", though I understand if this project doesn't want to get involved.

@artempyanykh
Copy link
Owner

Hi @ngraham20! Thanks for your contribution. I'd suggest keeping Helix in the list of supported editors, just rephrasing that it works out of the box if the binary is in PATH rather than fully deleting the section about Helix. Does it sound fine to you?

@ngraham20
Copy link
Contributor Author

Oh actually yeah, I hadn't thought of that, but yes seeing Helix specifically listed was what got me excited to begin with!

@ngraham20
Copy link
Contributor Author

I don't know whether GH notifys when new commits are added to an existing PR, but just in case, I re-added in the Helix support to the README doc

README.md Outdated Show resolved Hide resolved
@artempyanykh artempyanykh changed the title Removed Helix Editor Configuration from README Update README re: Helix editor configuration Oct 11, 2022
@artempyanykh
Copy link
Owner

@ngraham20 thank for adjusting the PR! There's just one more comment re: the phrasing

@ngraham20
Copy link
Contributor Author

ngraham20 commented Oct 11, 2022

Oh oops I marked resolved, thinking it would auto apply your suggestion. I can't tell if it did that or if I need to push the change myself. I'll check when I get to my computer

Co-authored-by: Artem Pyanykh <arr@fb.com>
@ngraham20
Copy link
Contributor Author

Ah, there we go, the mobile app doesn't have the "commit suggestion" button. I've updated the README with your suggestions.

@ngraham20
Copy link
Contributor Author

oh, super sorry, the label is "hacktoberfest-accepted". If you don't mind, could you swap that around?

@artempyanykh artempyanykh merged commit ab5a2c2 into artempyanykh:main Oct 12, 2022
@artempyanykh
Copy link
Owner

artempyanykh commented Oct 12, 2022

Fixed the label. Thanks for the contribution @ngraham20!

@ngraham20
Copy link
Contributor Author

Fixed the label. Thanks for the contribution @ngraham20!

Thank you! Glad to contribute :D

@ngraham20 ngraham20 deleted the doc-readme-helix branch October 12, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants