Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2-dimensional scrolling with touch pads. #111

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

SpaceshipOperations
Copy link
Contributor

This PR adds support for 2-dimensional scrolling, which is useful for touch
pad users.

In order to facilitate, the keyboard symbols that scroll events map into were
changed into the keypad up/down/left/right keys (so now we have four symbols
rather than two), and default bindings were added for those symbols so that
two-dimensional touch pad scrolling works out-of-the-box.

@artemsen
Copy link
Owner

Please, remove the dot from the commit subject, put your first comment into commit message, and add Signed-off-by to last line.

src/ui.c Outdated Show resolved Hide resolved
src/ui.c Outdated Show resolved Hide resolved
src/ui.c Show resolved Hide resolved
@SpaceshipOperations
Copy link
Contributor Author

SpaceshipOperations commented Jan 15, 2024

Please, remove the dot from the commit subject, put your first comment into commit message, and add Signed-off-by to last line.

Done.

Not enough one space and one space is excessive.

Fixed.

Do we really need this block?

Oh, I realized that the symbols were already defined. I removed the block.

Using keys for touch/mouse is a dirty hack.
I think we need own codes for that, may be not in this PR, but in the future.

I'm aware. I'm considering doing that myself, but I'd need to dig up some documentation/examples, so for the time being I went with the absolutely bare minimum modification lol.

Signed-off-by: Spaceship Operations <spaceshipoperations@gmail.com>
@artemsen artemsen merged commit d251479 into artemsen:master Jan 15, 2024
1 check passed
@artemsen
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants