Skip to content
This repository has been archived by the owner on Aug 6, 2023. It is now read-only.

Figwheel support #19

Closed
artemyarulin opened this issue Aug 8, 2016 · 0 comments
Closed

Figwheel support #19

artemyarulin opened this issue Aug 8, 2016 · 0 comments

Comments

@artemyarulin
Copy link
Owner

REPL is nice, but with Buck we broke usual Figwheel workflow - saving file doesn't do anything now as we are serving REPL from a different folder with source copies.

We cannot simply rerun build as it will clean up output folder first so all JS files gonna disappear.

Previously we had some fragile script which looks something like that:

project_dir=`buck build $2 && buck targets $2 --show-output | awk '{print $2}'`
tmp=`mktemp -d`
rsync -r $project_dir/ $tmp/
watchman-make -p 'lib/**/*' 'RULES/**/*' --make "buck build $2 && rsync -r $PWD/$project_dir/ $tmp/" -t '' & (cd $tmp && lein repl) && kill $!
artemyarulin pushed a commit that referenced this issue Aug 29, 2016
As discussed in #22 we eliminated any additional logic for testing - now test is just a module with it's own source files which depends on some other modules plus a flag that test runner has to be created. Doing that we were able to simplify lib.py and shift some of the logic to config.py. Closes #21

Initial implementation of REPL - again more details could be found in #22. It works fine, it's not yet ready to be released as sync is very slow and certain things (like :ext) are still hardcoded in the source, while it should be configurable. Closes #19
artemyarulin pushed a commit that referenced this issue Aug 29, 2016
As discussed in #22 we eliminated any additional logic for testing - now test is just a module with it's own source files which depends on some other modules plus a flag that test runner has to be created. Doing that we were able to simplify lib.py and shift some of the logic to config.py. Closes #21

Initial implementation of REPL - again more details could be found in #22. It works fine, it's not yet ready to be released as sync is very slow and certain things (like :ext) are still hardcoded in the source, while it should be configurable. Closes #19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant