Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning always appears when using custom user model #2

Closed
frewsxcv opened this issue Apr 15, 2016 · 4 comments
Closed

Warning always appears when using custom user model #2

frewsxcv opened this issue Apr 15, 2016 · 4 comments

Comments

@frewsxcv
Copy link
Contributor

https://github.com/arteria/django-hijack-admin/blob/e0773ff37777badfd35cf2d6ce09dfd5e46e536d/hijack_admin/checks.py#L23-L34

This warning seems to unconditionally appear when using a custom user model, even if one has the HijackUserAdminMixin mixed into their custom UserAdmin.

WARNINGS:
user.User: (hijack_admin.W001) django-hijack-admin does not work out the box with a custom user model.
    HINT: Please mix HijackUserAdminMixin into your custom UserAdmin.
frewsxcv added a commit to frewsxcv/django-hijack-admin that referenced this issue Apr 15, 2016
@frewsxcv
Don't warn about custom user model if correctly using mixin.
faec79b 
Fixes django-hijack#2.
@frewsxcv frewsxcv mentioned this issue Apr 15, 2016
Merged
@utapyngo
Copy link

Will you please release this fix?

@walterrenner
Copy link
Contributor

@utapyngo this Issue is still open. If you take a look at #3 you can see the tests have failed and the coverage decreases.

We'll release a new version as soon as this Issue can be closed.

@frewsxcv
Copy link
Contributor Author

I can look into writing a test for that PR later today.

frewsxcv added a commit to frewsxcv/django-hijack-admin that referenced this issue Apr 22, 2016
@frewsxcv
Don't warn about custom user model if correctly using mixin.
8113c4f 
Fixes django-hijack#2.
@frewsxcv
Copy link
Contributor Author

Added a working test. Coverage no longer decreases. 🎊

frewsxcv added a commit to frewsxcv/django-hijack-admin that referenced this issue Apr 22, 2016
@frewsxcv
Don't warn about custom user model if correctly using mixin.
d07269a 
Fixes django-hijack#2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frewsxcv @utapyngo @walterrenner