Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate output to single line for Google PageSpeed Insights #51

Closed
imuller opened this issue Feb 20, 2016 · 5 comments
Closed

Generate output to single line for Google PageSpeed Insights #51

imuller opened this issue Feb 20, 2016 · 5 comments
Labels

Comments

@imuller
Copy link

imuller commented Feb 20, 2016

Can the generate function be extended with one single line of html output? This gives an higher rank in Google PageSpeed Insights.

@vinicius73
Copy link
Member

You speak about no line break between the tags?

@vutranngocthanh
Copy link

hey how setup code

@jakemitchellxyz
Copy link
Contributor

I created a pull request for this.

@jakemitchellxyz
Copy link
Contributor

This is certainly not a problem this package should solve. It is however a
problem this package creates. It generates 20+ lines of code in some cases,
all of which just meta info. For that to be unminified it absolutely
unacceptable for an SEO plugin. This package has the potential to be very
widely used, but it never will until it adheres the MOST important aspect
of SEO: page loading speed. And I understand that minifying code could be
tedious, but my solution has 0 new lines of code. There is no reason NOT to
include it or a variation of it.
On Jun 23, 2016 11:08 PM, "William Oliveira" notifications@github.com
wrote:

In my opinion I dont think this is a problem this package needs to solve,
if you care about that you should use something that minifies the whole
page, maybe a middleware that minifies the html output or better, something
that minifies the cached views on /storage/framework/views


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANLCAEEvqIaUnrbzLxNngMeOTkEqs5Uuks5qO1hJgaJpZM4Hem9x
.

@williamoliveira
Copy link
Contributor

williamoliveira commented Jun 24, 2016

Yeah, I realized right before I sent that my second solution wouldn't work
as the html from this package is created dynamically before the view
caching process, in that case it is a valid problem,
but still, the other solution, minifying the whole page at the end of the
request works

2016-06-24 1:19 GMT-03:00 Jake notifications@github.com:

This is certainly not a problem this package should solve. It is however a
problem this package creates. It generates 20+ lines of code in some cases,
all of which just meta info. For that to be unminified it absolutely
unacceptable for an SEO plugin. This package has the potential to be very
widely used, but it never will until it adheres the MOST important aspect
of SEO: page loading speed. And I understand that minifying code could be
tedious, but my solution has 0 new lines of code. There is no reason NOT to
include it or a variation of it.
On Jun 23, 2016 11:08 PM, "William Oliveira" notifications@github.com
wrote:

In my opinion I dont think this is a problem this package needs to solve,
if you care about that you should use something that minifies the whole
page, maybe a middleware that minifies the html output or better,
something
that minifies the cached views on /storage/framework/views


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
<
https://github.com/notifications/unsubscribe/ANLCAEEvqIaUnrbzLxNngMeOTkEqs5Uuks5qO1hJgaJpZM4Hem9x

.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGC--CWZV4uw01FOjh1DQjBpks44ofHzks5qO1rngaJpZM4Hem9x
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants