Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPDoc methods of Facades #304

Merged
merged 1 commit into from
May 5, 2023

Conversation

chescos
Copy link
Contributor

@chescos chescos commented Apr 26, 2023

The PHPDoc method parameter types of some Facades are outdated. This breaks compatibility with static analysis tools like PHPStan.

This PR simply syncs the PHPDoc of the Fades with the PHPDoc of the Contracts.

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️

@J-Brk
Copy link
Collaborator

J-Brk commented Apr 27, 2023

Thank you for your contribution!

@J-Brk J-Brk mentioned this pull request Apr 28, 2023
@chescos
Copy link
Contributor Author

chescos commented May 4, 2023

Hey, any way to get this merged?

@J-Brk J-Brk merged commit 8f05ef8 into artesaos:master May 5, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants