-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grapesjs-mjml plugin no longer works with grapesjs 0.19.4 (and up) and React #297
Comments
Here is the example I used for testing if anyone would like to try recreating this: https://github.com/Drew-Daniels/grapesjs-react-bug |
After looking through the |
Still getting this with grapejs 0.20.4 and mjml 1.0.4 @Drew-Daniels solution of adding
works |
This has had a temporary fix for a long time. wondering if anyone knows if this is the final solution? |
My team has previously used
grapesjs v0.18.4
,grapesjs-mjml v0.6.6
andreact
together without issue. However, since the upgrade we made from0.18.4
to0.19.5
, the 3 no longer work together. I have created a simple example to illustrate the issue we're seeing.Summary:
When using
grapesjs v0.19.4
and up, whenever I try to drag a Section component onto a blank Canvas, I receive this warning:Video:
v0.19.4
and up:screen-capture (1).webm
v0.18.4
:screen-capture (2).webm
Here is my setup:
index.js
:App.js
:Builder.js
:config.js
:This appears to only be an issue when using
grapesjs v0.19.4
or higher along with thegrapesjs-mjml
plugin.What I have tried:
src/components/Body.js
:From:
To:
config.canvas.frameStyle
property to the following insrc/index.js
(line 67):mjml
througheditor.addComponents
(and removing my JSX mjml within#gjs
):Nothing works, the only thing that makes a difference is downgrading to the previous version, which we do not want to do because of the XSS vulnerabilities that come with doing so.
The text was updated successfully, but these errors were encountered: