Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24. Adds new configurable option to not shrink wrap list items #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

absar
Copy link

@absar absar commented Oct 3, 2022

Fixes #24. Adds new configurable option to not shrink wrap list items using S2ChoiceConfig.shrinkWrap or SmartSelect.single.choiceShrinkWrap/SmartSelect.multiple.choiceShrinkWrap.
If choiceShrinkWrap is true choices list will shrink wrap the choices, causing the list to resize based on the number of available choices, by default it will shrink wrap which was the default behaviour before this change.

Usage:

SmartSelect<T?>.single(
  choiceShrinkWrap: false
);
SmartSelect<T?>.multiple(
  choiceShrinkWrap: false
);

After fix if you pass SmartSelect.single.choiceShrinkWrap=false

SizeIssueFix.mp4

…list items using `S2ChoiceConfig.shrinkWrap` or `SmartSelect.single.choiceShrinkWrap`/`SmartSelect.multiple.choiceShrinkWrap`.

If `choiceShrinkWrap` is true choices list will shrink wrap the choices, causing the list to resize based on the number of available choices, by default it will shrink wrap which was the default behaviour before this change.
@absar
Copy link
Author

absar commented Oct 16, 2022

@vasilich6107 please merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make shrink wrapping items configurable to disable default behavior of resizing bottom sheet
1 participant