Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle single name field #1

Closed
artfulrobot opened this issue Aug 29, 2019 · 2 comments
Closed

Handle single name field #1

artfulrobot opened this issue Aug 29, 2019 · 2 comments

Comments

@artfulrobot
Copy link
Owner

If an action is configured without "Separate fields for first & last names" ticked then the extension fails to parse webhook data.

There may have been a change at iParl relating to this, or it may be just a new use case.

artfulrobot pushed a commit that referenced this issue Aug 29, 2019
@artfulrobot
Copy link
Owner Author

iParl appears to send lastname and surname but the docs https://iparlsetup.com/setup/help#supporterwebhook only refer to surname now. Updated code to use that.

@artfulrobot
Copy link
Owner Author

Note: it's still a BAD IDEA to not ask users to separate their own names into first and last

Only the user knows how to spell their name. We assume that:

  • a single name is a first name
  • "Bam Bam Flintstone Rubble" has first name "Bam", last name "Bam Flintstone Rubble" (but could actually be that first name is "Bam Bam" and last name is "Flintstone Rubble" or some other combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant